Closed epage closed 7 months ago
Attention: Patch coverage is 81.51659%
with 39 lines
in your changes are missing coverage. Please review.
Project coverage is 41.83%. Comparing base (
18a319a
) to head (55700b4
).
Files | Patch % | Lines |
---|---|---|
src/token/mod.rs | 66.66% | 16 Missing :warning: |
src/combinator/multi.rs | 59.25% | 11 Missing :warning: |
src/combinator/core.rs | 69.23% | 8 Missing :warning: |
src/binary/mod.rs | 94.82% | 3 Missing :warning: |
src/ascii/mod.rs | 95.83% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/ascii/mod.rs | 23 | 24 | 95.83% | ||
src/binary/mod.rs | 55 | 58 | 94.83% | ||
src/combinator/core.rs | 18 | 26 | 69.23% | ||
src/combinator/multi.rs | 16 | 27 | 59.26% | ||
src/token/mod.rs | 32 | 48 | 66.67% | ||
<!-- | Total: | 172 | 211 | 81.52% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/ascii/mod.rs | 1 | 55.75% | ||
src/combinator/parser.rs | 1 | 41.53% | ||
<!-- | Total: | 2 | --> |
Totals | |
---|---|
Change from base Build 8052977810: | -0.03% |
Covered Lines: | 1273 |
Relevant Lines: | 3043 |
Feedback
"simple" is meant to convey "basic". To avoid the mismatch between the language and people's potential experience, I've tried to find other words.
The naming has always bothered me but I still don't have a better idea. We can at least cross-reference and clarify the distinctions
This is meant to convey "greedy". For
take_while
, this is true. However,take_til
isn't greedy, so this was clarifiedWe're trying to step through the transformation from lower level code to higher level. I've tried to adjust that section to be more explicitly about that transformation. This also opened up an opportunity to call out the value of using a
Parser
is the helpers you can then use.