search

winnow-rs / winnow

Making parsing a breeze
https://docs.rs/winnow
Other
525 stars 40 forks source link

support wasm debug trace log #493

Closed baoyachi closed 6 months ago

baoyachi commented 7 months ago

fix #430

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 41.88%. Comparing base (85d4933) to head (033d60a).

Files Patch % Lines
src/combinator/debug/internals.rs 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #493 +/- ## ========================================== + Coverage 41.84% 41.88% +0.04% ========================================== Files 18 18 Lines 3047 3044 -3 ========================================== Hits 1275 1275 + Misses 1772 1769 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 8130788714

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/combinator/debug/internals.rs 0 7 0.0%
<!-- Total: 0 7 0.0% -->
Totals Coverage Status
Change from base Build 8101851502: 0.04%
Covered Lines: 1275
Relevant Lines: 3044
💛 - Coveralls
epage commented 6 months ago
baoyachi commented 6 months ago

So, What better ideas do you have for adapting wasm with debug tracing?

epage commented 6 months ago

So, What better ideas do you have for adapting wasm with debug tracing?

Like I said, I only looked at this enough to know this was not in a state to look at, so I can't say much more about this solution.

Might be good to post your proposal in the issue for us to discuss. Overall, this is not a priority for me, so I won't have much time to put to discussing this.