fix(dispatch): handle `#[...]` attributes

winnow-rs / winnow

Making parsing a breeze

https://docs.rs/winnow

Other

573 stars 46 forks source link

fix(dispatch): handle `#[...]` attributes #619

Open 39555 opened 1 week ago

39555 commented 1 week ago

Closes: #609

Handle #[...] attributes in dispatch! macro

coveralls commented 4 days ago

Pull Request Test Coverage Report for Build 11909745800

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 41.709%

Totals
Change from base Build 11802515306:	0.1%
Covered Lines:	1303
Relevant Lines:	3124

💛 - Coveralls

39555 commented 3 days ago

This is not related to the Pratt prs. I just resolved an issue that I knew how to fix by the way

epage commented 3 days ago

I appreciate it!

I bet seq! could also benefit from this ;)

(no obligation and not a blocker for this PR; incremental improvement is great!)

epage commented 3 days ago

As this is still a draft, I'm mostly holding off for now. Let me know when its ready (I don't think I get notifications for that) and please clean up the commits for how you want them reviewed and merged.