winoteam / react-router-navigation

⛵️ A complete navigation library for React Native, React DOM and React Router
MIT License
499 stars 49 forks source link

[IMPORTANT] 1.0.0-rc.5 fails #70

Open LeoLeBras opened 6 years ago

LeoLeBras commented 6 years ago

@CharlesMangwa @axeldelafosse

A new error occurred with 1.0.0-rc.5. I'll fix it as soon as I can ! 29257733_1573143326140716_102855546092126208_n

ma-pe commented 6 years ago

Any news on this? I'd love to see a new release, since i need the gesturesEnabled feature for a customer hands-on :)

LeoLeBras commented 6 years ago

Hey @ma-pe ,

Are you try to use gesturesEnable prop in react-router-navigation@1.0.0-rc.4 ? Maybe it should work.

I started using react-router-navigation on a new large application and I'm facing tons of issues. To correct them, I'm rewriting the package react-router-navigation-core. It takes me a lot of time and I am very busy right now to move forward as much as I would like. I'll try to do my best. I hope that within 3 weeks I will be able to release a new version, close to a stable version. I initially started this project as something experimental so it is necessary to consolidate some parts of the code now.

ma-pe commented 6 years ago

Thanks for your fast reply. gesturesEnabled prop hit master after the rc.4 (https://github.com/LeoLeBras/react-router-navigation/commit/80b7a0fd3a7e6a9a27b17a7e2e43132966588e10). I will try to locally build this commit since it isn't possible to add react-router-navigation via yarn add ...#commit-hash.

I love this library and I am excited for every commit/release. Keep up the good work!

ma-pe commented 6 years ago

@LeoLeBras: Now I see what you mean. The commit was just docs and typedefinitions for an existing react-navigation prop.

Just using it in rc-4 doesn't work though:

<Navigation
  ...
  gesturesEnabled={false}
>

<Card
  ...
  gesturesEnabled={false}
/>

I'll try to find out what I am missing here.

LeoLeBras commented 6 years ago

Maybe it's related to an older version of react-navigation. 😞 I apologize for not publishing a version of the application with support for gesturesEnabled prop. To correct this issue, I am forced to do a lot of refactoring and it takes a long time. But it's coming!

ma-pe commented 6 years ago

No worries! I am exited for the next release :)

timsawtell-sportsbet commented 6 years ago

Hi Leo, any updates?

ahmedu007 commented 6 years ago

Hey, thanks for all the awesome transitions, but any chance that you are still going to maintain this library? Could really do with that gestures on some routes. Thanks