search

winsiderss / phnt

Native API header files for the System Informer project.
https://github.com/winsiderss/systeminformer
MIT License
991 stars 166 forks source link

fix default OS version description in README.md #28

Closed ranni0225 closed 8 months ago

ranni0225 commented 11 months ago

It seems that the default OS version is Windows 7 since first commit?

// phnt.h
#ifndef PHNT_VERSION
#define PHNT_VERSION PHNT_WIN7
#endif
dmex commented 11 months ago

It seems that the default OS version is Windows 7 since first commit?

This is a standalone repository without the history. There can be hundreds of changes upstream and only when those changes are considered stable they are merged into this repository into a single commit and history of this repository does not get synchronized from the upstream parent repository.

The original value was PHNT_WIN2K in 2010: https://github.com/winsiderss/systeminformer/commit/a5496a851ade092548009d89c64e321c564669bf

It was then changed to PHNT_WINXP almost 14 years ago: https://github.com/winsiderss/systeminformer/commit/5f102f6bd25718edd2da76632acdf5dae759ff2f

We attempted to change the level in 2016 to PHNT_WIN7: https://github.com/winsiderss/systeminformer/commit/e6286416f426b244c2f9caa16ceb9aba5046afc7

Reverted back to PHNT_WINXP: https://github.com/winsiderss/systeminformer/commit/ca8e91a415bf8db01cdd04c8e188fd28588fd9d0

Finally updated to PHNT_WIN7 in 2017: https://github.com/winsiderss/systeminformer/commit/2c047c9517018c9824cd44e5f96c353347a49977

only definitions present in Windows XP

This is still technically true because newer lib files are not included and the minimum support is XP.