search

winsiderss / systeminformer

A free, powerful, multi-purpose tool that helps you monitor system resources, debug software and detect malware. Brought to you by Winsider Seminars & Solutions, Inc. @ http://www.windows-internals.com
https://systeminformer.sourceforge.io
MIT License
10.82k stars 1.38k forks source link

Bug?/Feature : Clicking system information graph should open system information window #1094

Open SanderBouwhuis opened 2 years ago

SanderBouwhuis commented 2 years ago

Sooooooo often I click on one of the system information graphs only to be surprised that it doesn't actually open the system information window. Then I have to move the mouse over to the 'system information' toolbar icon to actually open the system information window.

Is there a setting I have missed?

If not, then please, please, please, make it such that when you click a graph it will open the system information for that graph. E.g., if I click the 'Cpu history' graph in the toolbar, the system information window should open with the cpu history selected.

dmex commented 2 years ago

when you click a graph it will open the system information for that graph

When you double click the graphs they show the process with the highest utilization for that time. This is the same behavior as the system information graphs where double clicking shows the process?

It could be changed but I assumed having the same behavior for both sets of graphs is the expected behavior?

SanderBouwhuis commented 2 years ago

Sorry, I mean in the main GUI. When I click one of the graphs, why not open the System Information window of that graph?

ProcessHacker

dmex commented 2 years ago

I mean in the main GUI

Those are the same graphs I was talking about.

When I click one of the graphs, why not open the System Information window of that graph?

Because:

When you double click the graphs they show the process with the highest utilization for that time

This is the current behavior, clicking opens the process properties just like all the other graphs.

why not open the System Information window of that graph?

The problem is:

the same behavior for both sets of graphs is the expected behavior

I can change it to open the system information graph but someone else is then going to create an issue asking why it suddenly doesn't open the properties anymore because that's how they've been using those main window graphs until now.

I'm just waiting to see if anyone comments about the current behavior to give some idea of what could be done. Either using settings to toggle what the clicking does or maybe removing the old behavior?

SanderBouwhuis commented 2 years ago

You keep talking about double clicking. I'm talking about single clicking.

DOUBLE left mouse button click : current behaviour of showing 'highest utilization'. SINGLE left mouse button click : open System Information window (preferably immediately with the correct tab selected).

dmex commented 2 years ago

I'm just waiting to see if anyone comments about the current behavior

The latest nightly now opens the sysinfo graphs by default. A new setting was added ToolbarShowSystemInfoGraph to restore the previous behavior 👍

open System Information window (preferably immediately with the correct tab selected).

This is now the default.

SanderBouwhuis commented 2 years ago

@dmex Super excited! I tried the version, but there are a few bugs:

  1. You replaced the double click functionality instead of setting it to single click. Now we have the situation that we miss functionality for double-clicking.
  2. You replaced the double click functionality instead of setting it to single click and added a nearly impossible to find advanced option and didn't activate it. This means I may be the only one in the world who actually knows about this potentially helpful but un-discoverable feature.
  3. You implemented it inconsistently. For some graphs it works : CPU, physical memory, IO, commit charge For some graphs it fails : Disk, GPU, network