jxy-s
commented
2 years ago We could do with a readme in the build folder with some more detailed information on building the project along with some of the gotchyas/errata around it. Saving the build times on thirdparty.lib in the pipeline is worth the occasional headache. A little documentation here on things that can go sideways in different one-off build environments should help eliminate some confusion.
I'm going to link to the build readme from the top level readme to help guide people to that location if they encounter build problems.
More specifically some developers are using mismatched compilers: https://github.com/winsiderss/systeminformer/discussions/1335
This issue could be mitigated by adding a pre-build step to ensure that the thirdparty.lib is built with the same compiler. The intention behind having it checked in was to minimize build times and complexity. We should investigate the cost of building third party as a pre-build step. If the cost is too high with respect time/complexity we might just want to continue to handle these as a case-base-case basis, document it better, or investigate a better error/communication within the build tools to explain that developers need to rebuild third party for their compiler.