winsiderss / systeminformer

A free, powerful, multi-purpose tool that helps you monitor system resources, debug software and detect malware. Brought to you by Winsider Seminars & Solutions, Inc. @ http://www.windows-internals.com
https://systeminformer.sourceforge.io
MIT License
11.07k stars 1.4k forks source link

Downloading updates never works #1982

Open SanderBouwhuis opened 9 months ago

SanderBouwhuis commented 9 months ago

Every time there is a popup showing there is an update, it says the download fails. Pressing retry doesn't help either. I've never been able to update System Informer. With Process Hacker I never had that issue.

I have installed System Informer in the default directory.

dmex commented 8 months ago

What message does the updater show when the download fails?

Alternately you can just re-run the installer: https://systeminformer.sourceforge.io/nightly.php

A-tG commented 8 months ago

I have similar problem. It installed to custom folder and I get "Error downloading update" for months or even half of year. Installer re-run doesn't help.

Biswa96 commented 8 months ago

I can not reproduce the issue in my system. SystemInformer automatically updates itself since first installation.

SanderBouwhuis commented 8 months ago

Here is what I get:

https://github.com/winsiderss/systeminformer/assets/10495173/6f795167-2a08-41b9-b736-1c2bc6b14626

dmex commented 8 months ago

@SanderBouwhuis

It could either be the host or firewall. I've changed the hosting provider, try checking for updates again.

If it's still failing then select the Firewall tab before checking for updates and make sure there are no [BLOCKED] entries for SystemInformer.exe

SanderBouwhuis commented 8 months ago

@dmex It still doesn't work. Please give me the update domain. Then I'll check my firewall rules. Having said that, I have used ProcessHacker for many years and there I never had trouble with updating (it's something relatively new).

jxy-s commented 8 months ago

The "normal" hosting location is here: https://github.com/winsiderss/si-builds/releases @dmex changed it to this in the database: https://d2zvcf2q9m0etg.cloudfront.net/systeminformer-3.0.7474-setup.exe

It seems the client is successfully making the first request to query the update service, but failing later. The domains queried are these, in order:

systeminformer.sourceforge.io/nightly.php?update
system-informer.com/nightly.php?update
systeminformer.com/nightly.php?update

See: https://github.com/winsiderss/systeminformer/blob/e904d245241276a6e0677d1283a53a6a6fc63d69/plugins/Updater/updater.c#L399-L408 What do those return to you in a web browser?

Based on the behavior in the video it seems like it's being blocked from making the the second request to download the setup_url.

SanderBouwhuis commented 8 months ago

All three redirect to this url: https://systeminformer.com/version.php

This is what I get in Firefox: `

  |   -- | -- version | "3.0.7474" updated | "2024-03-02T00:53:04.1226055+00:00" commit | "e904d245241276a6e0677d1283a53a6a6fc63d69" bin_length | "15128693" bin_hash | "CBB610DE52E8B03BD705C589FB76A73C839E0273B67986FA4C027E93D8A364B2" bin_sig | "8ab485e3d6c596887030704a46773cd68b7b175b33bdf3e2d29b340715a76e0f1c00438886143c0bf014001279b2993e70472fc6d28104dc98a6a55e4d9fd3c8" bin_url | "https://github.com/winsiderss/si-builds/releases/download/3.0.7474/systeminformer-3.0.7474-bin.zip" setup_length | "15670752" setup_hash | "E367EC6231B48085349DA0315366B04A6BD94BBD7DBEE2D743C17A89CA44AA22" setup_sig | "6d163c3b5d771bce14e364bff49fc3cb2818e54b95cb62d89dd5ada4f79461da6f2de151f3248be76894f5552106120e1ba9b648b96e003e9e0265b0be254eb8" setup_url | "https://d2zvcf2q9m0etg.cloudfront.net/systeminformer-3.0.7474-setup.exe"

`

jxy-s commented 8 months ago

Looks like you're getting the right setup_url and downloading manually, I assume, works.

Please give me the update domain. Then I'll check my firewall rules.

Let us know if you discover anything here.

SanderBouwhuis commented 8 months ago

When I try to download https://d2zvcf2q9m0etg.cloudfront.net/systeminformer-3.0.7474-setup.exe, it works in Firefox.

I tried again in SystemInformer, and made a Wireshark capture. Here is the Wireshark log (I filtered on the Cloudfront server): Wireshark log SystemInformer.zip It's actually a 7z file, but this forum only allows files with certain extentions, so I named it .zip

dmex commented 8 months ago

@SanderBouwhuis The host requires TLS 1.2 on Windows 10 and yours was probably disabled?

SanderBouwhuis commented 8 months ago

That is not it. TLS v1.2 is enabled by default on Windows 10:

TLS v1 2 settings Windows 10

A-tG commented 8 months ago

Suddenly update works for me

SanderBouwhuis commented 3 weeks ago

It still doesn't work for me, but now the error changed:

2024-10-27 07-12-34 402x149 System_Informer_-_Updater

Settings not saving anymore, updating not working... this project is sooooo buggy. It used to work really well when it was still ProcessHacker ;-(