search

winsiderss / systeminformer

A free, powerful, multi-purpose tool that helps you monitor system resources, debug software and detect malware. Brought to you by Winsider Seminars & Solutions, Inc. @ http://www.windows-internals.com
https://systeminformer.sourceforge.io
MIT License
10.88k stars 1.38k forks source link

unreachable code inside `PhGenerateSyscallLists` #2027

Closed oberrich closed 5 months ago

oberrich commented 5 months ago

Brief description of your issue

https://github.com/winsiderss/systeminformer/blob/342ef190cb717f43a4bcfd30eeb7095909106644/SystemInformer/ksyscall.c#L184-L214

is unreachable due to earlier check here

https://github.com/winsiderss/systeminformer/blob/342ef190cb717f43a4bcfd30eeb7095909106644/SystemInformer/ksyscall.c#L109

dmex commented 5 months ago

This is intentional. This branch of code is not used at all and is optimized away at compile time but will very likely be required again in the future and when it does, we can just flip the version check to start using it again when needed.