search

winsiderss / systeminformer

A free, powerful, multi-purpose tool that helps you monitor system resources, debug software and detect malware. Brought to you by Winsider Seminars & Solutions, Inc. @ http://www.windows-internals.com
https://systeminformer.sourceforge.io
MIT License
10.53k stars 1.36k forks source link

GeoLite database update broken in systeminformer-3.1.7741-canary-bin #2088

Closed Almighty188 closed 3 weeks ago

Almighty188 commented 3 weeks ago

Brief description of your issue

It appears GeoLite database update is broken in systeminformer-3.1.7741-canary-bin but works correctly in systeminformer-3.0.7660-canary-bin using SystemInformer.exe.settings.xml with the exact same contents

Steps to reproduce (optional)

1) Run amd64\SystemInformer.exe as admin 2) Then either Tools, Network Tools, GeoLite database update... or System, NetworkTools, Download Update where the MaxMind GeoLite License Key is already filled out.

Expected behavior (optional)

It is supposed to update like systeminformer-3.0.7660-canary-bin immediately after systeminformer-3.1.7741-canary-bin failed:

image

Actual behavior (optional)

systeminformer-3.1.7741-canary-bin shows: image

systeminformer-3.0.7660-canary-bin works correctly after I quit systeminformer-3.1.7741-canary-bin as mentioned in expected behavior with:

image

Environment (optional)

System Informer version 3.1.7741-canary-bin
Windows Insider Beta Build 22635.3720 (23H2)
Almighty188 commented 3 weeks ago

I found the issue, the error message says it needs either the GeoLite ID or Key but in reality, it needs both the GeoLite ID and Key.

image

I know only the key works in the older version of systeminformer as mentioned earlier. Just entering the GeoLite ID without the key does not work as systeminformer will complain about the License key being required.

image
dmex commented 3 weeks ago

Changes to MaxMind License Keys: https://dev.maxmind.com/geoip/release-notes/2023#changes-to-maxmind-license-keys

Duplicate of #2069

Almighty188 commented 3 weeks ago

Changes to MaxMind License Keys: https://dev.maxmind.com/geoip/release-notes/2023#changes-to-maxmind-license-keys

Duplicate of #2069

Not exactly a duplicate since it's the error message that needs to be fixed as in 3.1.7741:

The bug is that if you look at the error message, it says ID "or" key, not ID "and" key which would be telling the user they only needed either the ID "or" key and not both.

image