search

winsiderss / systeminformer

A free, powerful, multi-purpose tool that helps you monitor system resources, debug software and detect malware. Brought to you by Winsider Seminars & Solutions, Inc. @ http://www.windows-internals.com
https://systeminformer.sourceforge.io
MIT License
10.53k stars 1.36k forks source link

Fixed compilation error. #2106

Closed trparky closed 1 week ago

trparky commented 1 week ago

Fixed a compilation error mentioning a potentially uninitialized local pointer variable named 'fileName'.

dmex commented 1 week ago

Try running \build\build_clean.cmd and clear the cache because the SAL annotations for out parameters don't have uninitialized warnings.

trparky commented 1 week ago

Try running \build\build_clean.cmd and clear the cache because the SAL annotations for out parameters don't have uninitialized warnings.

PS C:\Users\trpar\source\repos\systeminformer\build> .\build_clean.cmd Removing SystemInformer/obj/Removing SystemInformer/sdk/phapppub.hRemoving bin/Removing build/output/Removing kphlib/bin/Removing kphlib/obj/Removing phlib/bin/Removing phlib/obj/Removing plugins/DotNetTools/obj/Removing plugins/ExtendedNotifications/obj/Removing plugins/ExtendedServices/obj/Removing plugins/ExtendedTools/obj/Removing plugins/HardwareDevices/obj/Removing plugins/NetworkTools/obj/Removing plugins/OnlineChecks/obj/Removing plugins/ToolStatus/obj/Removing plugins/Updater/obj/Removing plugins/UserNotes/obj/Removing plugins/WindowExplorer/obj/Removing sdk/Removing tools/CustomBuildTool/.vs/Removing tools/CustomBuildTool/bin/Debug/Removing tools/CustomBuildTool/obj/Removing tools/CustomSetupTool/bin/Removing tools/CustomSetupTool/obj/Removing tools/peview/obj/

Build Time: 0 minute(s), 0 second(s)

Press any key to continue . . . PS C:\Users\trpar\source\repos\systeminformer\build> .\build_release.cmd Windows: 10.0.22621.3733 (WinBuild.160101.0800) WindowsSDK: 10.0.22621.0 (17.10.34803.213) VisualStudio: VisualStudio/17.10.3+35013.160

Building... 3.1.12319.7792 (0fa94ef) [master]

[00:00] Building SystemInformer (Win32)... [ERROR] (1) SystemInformer\thrdprv.c(340): error C4703: potentially uninitialized local pointer variable 'fileName' used [C:\Users\trpar\source\repos\systeminformer\SystemInformer\SystemInformer.vcxproj]SystemInformer\sysscmem.c(1056): error C4703: potentially uninitialized local pointer variable 'kernelFileName' used [C:\Users\trpar\source\repos\systeminformer\SystemInformer\SystemInformer.vcxproj]LINK : fatal error LNK1257: code generation failed [C:\Users\trpar\source\repos\systeminformer\SystemInformer\SystemInformer.vcxproj] Press any key to continue . . .

trparky commented 1 week ago

Something must have changed in another commit because the code compiles as is without these changes that I made a pull request for. I'm closing this pull request since it appears that it's not needed anymore.