search

winsiderss / systeminformer

A free, powerful, multi-purpose tool that helps you monitor system resources, debug software and detect malware. Brought to you by Winsider Seminars & Solutions, Inc. @ http://www.windows-internals.com
https://systeminformer.sourceforge.io
MIT License
10.53k stars 1.36k forks source link

CustomBuildTool problem with compilation #2108

Closed henrypp closed 2 days ago

henrypp commented 1 week ago

Brief description of your issue

1) Your CustomBuildTool was made SI with version 0.0 (it is not cool, because i need to refute every start SI because of updater), and i know that you changed this tool, but...

sshot-003

2) Error:

sshot-004 25/06/2024 now it fixed!

Steps to reproduce (optional)

No response

Expected behavior (optional)

No response

Actual behavior (optional)

No response

Environment (optional)

No response

MagicAndre1981 commented 1 week ago

there is already the PR #2106 to fix it

trparky commented 1 week ago

My pull request, namely https://github.com/winsiderss/systeminformer/pull/2106, has been closed by me (the author). As I mentioned in the closing comments, something must have changed in another commit to fix this issue since now the code compiles without incident even without my changes.

henrypp commented 1 week ago

25/06/2024 now it fixed!

my comment above.

@trparky it is noting changed even in SI repo (or i did not find it), but compile is A-OK, all good, only 0.0 version was not changed by now

trparky commented 1 week ago

Excuse me. What?

henrypp commented 1 week ago

@trparky custombuild tool was create binary with version 0.0, all in this issue

trparky commented 1 week ago

This? https://github.com/winsiderss/systeminformer/commit/456731b8f90f64a4a050b8d2ff9528c44f5ec3d6

henrypp commented 1 week ago

@trparky maybe, even recompile custombuildtool was generate binary with version 0.0

trparky commented 1 week ago

@trparky maybe, even recompile custombuildtool was generate binary with version 0.0

Yeah, that's weird. I wonder what difference it makes.

henrypp commented 1 week ago

@trparky that is strange answer - updater will bring every start and tell me that new version available

henrypp commented 2 days ago

now, i think, problem are solved

sshot-003