isEffective is a simple function that checks whether the attacker is effective against the enemy's weapon or not. Loptous added a new type of weakness to the table, that's why this is needed. Maybe a better name would be is_Effective_weapons...
The function that has the bladetome check now checks for Legault's weapon too and uses the enemy's buffes. All standard here.
Since combat buffes are handled at a different time than effectiveness, I had to check for effectiveness to determine whether Loptous' malus applies or not. Also changed the combat buffes' text to include the case in which you get a malus.
Yato brought a new issue up: the weapon edits stats in every one of its refine. Had to fix the code and make it check if every refine updates stats too.
Made it so Nifl Frostflowers and Muspell's Fireposy use the same code as owltomes. In the future I'll edit the owltomes so they TOTALLY use the same logic to avoid having that base case.
Made a check for Vessal's Blade and Giga Excalibur based off on the Light Brand's one. Forgot to change the comment on top of it. Objective it to merge this one with Light Brand's one when I have some spare time.
Sooo...
isEffective is a simple function that checks whether the attacker is effective against the enemy's weapon or not. Loptous added a new type of weakness to the table, that's why this is needed. Maybe a better name would be is_Effective_weapons...
The function that has the bladetome check now checks for Legault's weapon too and uses the enemy's buffes. All standard here.
Since combat buffes are handled at a different time than effectiveness, I had to check for effectiveness to determine whether Loptous' malus applies or not. Also changed the combat buffes' text to include the case in which you get a malus.
Yato brought a new issue up: the weapon edits stats in every one of its refine. Had to fix the code and make it check if every refine updates stats too.
Made it so Nifl Frostflowers and Muspell's Fireposy use the same code as owltomes. In the future I'll edit the owltomes so they TOTALLY use the same logic to avoid having that base case.
Made a check for Vessal's Blade and Giga Excalibur based off on the Light Brand's one. Forgot to change the comment on top of it. Objective it to merge this one with Light Brand's one when I have some spare time.