search

winsomniak / kagero-calc

Fire Emblem Heroes Combat Simulator
https://kagerochart.com/damage-calc
MIT License
8 stars 3 forks source link

Update summer #109

Closed Lorenzooone closed 6 years ago

Lorenzooone commented 6 years ago

Commits explain what is what. Fixed some bugs and changed the design. Remember to include Green Bow's icon, Colorless Breath's icon and to swap the Morgans portraits.

Lorenzooone commented 6 years ago

I can't seem to get Custom units icon working... It stays the same if you change movement type and/or weapon type and the same happens on the site. The unit gets properly modified though... Do you have any idea on what might be causing this?

winsomniak commented 6 years ago

Custom unit icon as in their avatar?

I think the avatar was always a silhouette for custom units in previous versions. I may not be understanding your question correctly though.

Lorenzooone commented 6 years ago

cattura Changing these ones doesn't change the respective icons, both on this pull request and on the site. (The battle simulation updates fine though)

winsomniak commented 6 years ago

Ahh ok, Ill have to look into this. Custom units have a bunch of edge casey code that I've not changed much since the legacy version.

On Sun, Jul 8, 2018, 12:05 PM Lorenzooone notifications@github.com wrote:

[image: cattura] https://user-images.githubusercontent.com/7537905/42422171-b3ee18ce-82e1-11e8-8590-387bfe5ecd8b.PNG Changing these ones doesn't change the respective icons, both on this pull request and on the site. (The calc updates fine though)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/winsomniak/kagero-calc/pull/109#issuecomment-403301596, or mute the thread https://github.com/notifications/unsubscribe-auth/AK3mrU4uKC48qkQDHvneJm-eNq2_8baBks5uEjvRgaJpZM4VGdGD .