winsomniak / kagero-calc

Fire Emblem Heroes Combat Simulator
https://kagerochart.com/damage-calc
MIT License
8 stars 3 forks source link

Stats Below Minimum Set to 1, Adding/Removing Skills Bring Stats to Incorrect Values #27

Closed winsomniak closed 5 years ago

winsomniak commented 6 years ago

As reported by Moxie on Discord

"man if ogma came as a 1* unit will his res go into the negatives oh hey there's abug on kagchart if you put LD on -res lv 1 Ogma(edited) and then take it off it puts his res back at...6 and not 1 edge cases! @Moxie probably should let winsomniak know"

winsomniak commented 6 years ago

I confirmed this one, but its quite old.

YukariTea commented 6 years ago

Additionally, the minimum stat should be 0, not 1.

winsomniak commented 6 years ago

Fix might be pretty involved, since there are many places in the code that decrease stats.

Lorenzooone commented 5 years ago

Fixed in the next update. https://github.com/winsomniak/kagero-calc/commit/02e695e3236deed01862cf428f101539cbf3daa0