search

winsomniak / kagero-calc

Fire Emblem Heroes Combat Simulator
https://kagerochart.com/damage-calc
MIT License
8 stars 3 forks source link

Investigate and resolve browser compatibility issues being reported intermittently #40

Open winsomniak opened 6 years ago

winsomniak commented 6 years ago

People on certain browsers and operating systems, especially old ones, seem to report having problems where the damage calc doesn't do anything. I have not been able to pin this down yet, and in one or two instances, people reported it working later. Possibly a rare issue related to the initial load.

The simulator matches up two random heroes, so it could be a bug with that and not actually a browser issue. Requires more investigation to say for sure.

winsomniak commented 6 years ago

Also note that there could be multiple issues here, I'm not sure.

Lorenzooone commented 6 years ago

There was an issue that I noticed where if Mia was the first random attacker, then things wouldn't work. This was due to a wrong variable being used (uppercase and lowercase type of stuff). I fixed it in the latest update, so it could be it. In general it was regarding the phantom stuff.

astranberg commented 6 years ago

I am having this issue consistently, and I would be willing to troubleshoot this with you. Windows 10, Internet Explorer 11 has an issue where the page does not render correctly and the form is not usable. I believe the issue is with the javascript. Link to a screenshot below.

https://imgur.com/a/Rs2YW

A couple notes:

A couple links on the 'foreach' issue below.

winsomniak commented 6 years ago

Hey @astranberg, thanks for the report!

IE is known to be problematic and I have not yet had the time to polyfill missing IE functionality. Should work better on chrome or firefox.

Java isn't used by the calc or kagerochart so that shouldn't matter. Note that Java and Javascript are entirely different things :)

Thanks for the details and screenshots! Opening up the JS console helps a lot in identifying the incompatibilities. Seriously appreciate you doing that.

Lorenzooone commented 6 years ago

BTW, some issues on edge too... But changing something in the data (a refresh) fixes them.

astranberg commented 6 years ago

You're welcome @winsomniak.

I do need the website to work with IE. If you found a fix that would be awesome. Reason being: I am working on a little project using VBA (with Excel) that uses your website to iterate through some calculations and work with the form. Unfortunately the only browser I can use with VBA is IE11.

Thanks for your hard work.

P.S. my Edge works fine with using it as @Lorenzooone mentioned

winsomniak commented 6 years ago

These problems may or may not be resolved in the next update. If they aren't, I'll eventually patch things up with webpack and/or babel + polyfills.