search

winsomniak / kagero-calc

Fire Emblem Heroes Combat Simulator
https://kagerochart.com/damage-calc
MIT License
8 stars 3 forks source link

Community Update #75

Closed Lorenzooone closed 6 years ago

Lorenzooone commented 6 years ago

The testing setup (BTW, thanks a LOT for sharing it) doesn't seem to use the data from the local data folder... Could this be fixed? I'll try doing it myself once I'm back from swimming, but, if I won't be able to figure it out, some help would be appreciated.

Edit: Init.js is the culprit

winsomniak commented 6 years ago

Ah I forgot to make a note of this!

The calc pulls all data from the live version of KageroChart currently. KageroChart concthe data from the calc as part of the response.

Its not ideal after opening up the source, because its harder for 3rd parties to test. I need to do a bit off design work on this, as my intent was for KageroChart and the calc to use the same datasource.

If you'd like to take a temporary measure, just change init.js to load from a static file instead of https://kagerochart.com/damage-calc/data. Just be aware that I may need to modify this behavior in the coming weeks.

On Feb 16, 2018 10:49 AM, "Lorenzooone" notifications@github.com wrote:

The testing setup (BTW, thanks a LOT for sharing it) doesn't seem to use the data from the local data folder... Could this be fixed? I'll try doing it myself once I'm back from swimming, but, if I won't be able to figure it out, some help would be appreciated.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/winsomniak/kagero-calc/issues/75, or mute the thread https://github.com/notifications/unsubscribe-auth/AK3mrXcSGMqqcqe_E_hnesPxhxHEt4cQks5tVbGigaJpZM4SIndV .