winston-lim / pe

1 stars 0 forks source link

External API calls are not captured #8

Open winston-lim opened 1 year ago

winston-lim commented 1 year ago

Argument is that external API calls are external(and not internal) and so at least 1 diagram/documentation should show that, perhaps in 2.3 API Component

soc-pe-bot commented 1 year ago

Team's Response

Hi, thank you for raising this issue to us. We appreciate your feedback but we have to reject this issue due to the following reason below.

Since API calls are external, and they may not a class, we are unable to place that in an object class diagram (section 2.3). Furthermore in the sequence diagram stated in section 3.3, we do explain which methods interacted with the api.

Screen Shot 2022-11-14 at 10.37.59.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I argue that it is important to show that you are indeed calling an external API call which could've been done quite easily.