search

winston / google_visualr

A Ruby Gem for the Google Visualization API. Write Ruby code. Generate Javascript. Display a Google Chart.
http://googlevisualr.heroku.com
MIT License
428 stars 100 forks source link

Don't force english language #98

Closed ledermann closed 9 years ago

ledermann commented 9 years ago

In #96, the languageoption was introduced. Unfortunately, it forces the language to be english, if the option is not set. This breaks the browser detection. Please see the docs:

By default, the Google Chart libraries are loaded with the locale specified by the browser

This PR removes the fallback

winston commented 9 years ago

Good catch! My bad! Merging and releasing a new patch. Thanks! :bow:

winston commented 9 years ago

New version up on https://rubygems.org/gems/google_visualr

ledermann commented 9 years ago

Wow, this was fast - thanks!