search

winstonewert / redux-reactions

A reactions approach to side-effects in redux.
MIT License
6 stars 2 forks source link

connectWithReactions #2

Closed kurtharriger closed 8 years ago

kurtharriger commented 8 years ago

In my initial review of the source I totally missed that for some containers connect was replaced with your own version connectWithReactions and was trying to figure out how reactions was getting attached to the component.

I think I would avoid shadowing the existing name. Just call it connectWithReactions to avoid the ambiguity.