search

winstonjs / node-loggly

A client implementation for Loggly in node.js
http://github.com/winstonjs/node-loggly
Other
233 stars 80 forks source link

Add removeDevice and device.remove(), tests, and improved test configuration #22

Closed rosskukulinski closed 11 years ago

rosskukulinski commented 11 years ago

With this pull request I've implemented the removeDevice() and device.remove() functionality in the Loggly API and I have implemented tests that verify their functionality.

I also made a modification to the test-config.json file format which explicitly sets the Loggly input names used in the test. We already had an input named 'test' in our Loggly account which the tests were trying to use, rather than the inputs we created for testing this library.

Now developers must specify the input names along with the ID and token in test-config.json.

Feedback welcome.

rosskukulinski commented 11 years ago

Thanks @indexzero. Could you ping me if/when you bump version for npm?