search

winstonjs / node-loggly

A client implementation for Loggly in node.js
http://github.com/winstonjs/node-loggly
Other
233 stars 80 forks source link

bump version to 0.3.12 #27

Closed nicco closed 10 years ago

nicco commented 11 years ago

This version of node-loggly is now unusable with Loggly V2 since the api url changed, the fix that allowes custom URLs has been already merged 2 months ago but the package version has not been bumped

indexzero commented 11 years ago

Is it just custom URLs that enables the V2 api? I've spoken with the Loggly team and it appears this is not all that needs to be done.

cc/ @ltudury @joseph12631

nicco commented 11 years ago

I have 2 Loggly accounts one with V1 and the other with V2. I cannot get my logs in V2 with the V1 API url.

Following the page http://www.loggly.com/docs/api-sending-data/ you can see that now Loggly V2 has a different API url for sending data. If I substitute in node-loggly the old url with the new one I can send my data to my V2 account.

No matter what, the version should be bumped since many modifications have been done from the last time it was bumped.

nicco commented 11 years ago

from Loggly: Thanks for requesting that pull request. We have gotten in contact with Charlie and shared what he requested to ammend the library he wrote as far as Gen1 is concerned. It appears that your assumption is correct. That being said we will defer any pull requests to Charlie since we did not write node-loggly.

So as they say it's up to you but if we don't bump teh version we cannot use this library for V2

Thanks!

Jpro714 commented 11 years ago

+1. As a new user this was super frustrating and burned most of today trying to track down what the issue was and why I couldn't modify inputUrl

bvarga commented 11 years ago

+1

kb19 commented 11 years ago

A suitable solution I found was just swapping out the version number in the package.json for the github url until the version number is updated.

"loggly": "git://github.com/nodejitsu/node-loggly.git#master"
robraux commented 11 years ago

:+1: Would much rather have a tagged version, please?

jcrugzz commented 10 years ago

Hey all, checkout the newest 1.0.0 release!