search

winstonjs / node-loggly

A client implementation for Loggly in node.js
http://github.com/winstonjs/node-loggly
Other
233 stars 80 forks source link

Ensure that query parameters are valid before submitting to Loggly #9

Closed indexzero closed 13 years ago

indexzero commented 13 years ago

We should be checking the FROM and UNTIL parameters in the Loggly.prototype.search method to ensure that:

  1. They are from the set of accepted parameters by Loggly: http://wiki.loggly.com/searchguide
  2. The time range actually exists (i.e. disallow things like FROM=NOW&UNTIL=NOW-1DAY

@kordless Any input on this?

ghost commented 13 years ago

@indexzero is this officially assigned to me?

indexzero commented 13 years ago

@nicoreed yes. Let me know if you have any questions about this module.

indexzero commented 13 years ago

@nicoreed I wrote a custom DateTime parser for the Loggly date format and published it as timespan@v2.1.0 in npm. Can you take that library as a dependency in node-loggly do the make the check we discussed?

And yes ... it was a very non-trivial problem. Ended up being more more difficult than I expected.

indexzero commented 13 years ago

@nicoreed I was on a roll this evening / morning and just got this wrapped up. False alarm.