search

winstonjs / winston-daily-rotate-file

A transport for winston which logs to a rotating file each day.
MIT License
889 stars 151 forks source link

Pass 'audit_hash_type' option for getStream method #344

Closed patilms16 closed 2 years ago

patilms16 commented 2 years ago

Adding 'audit_hash_type' option while using .getStream to avoid unsupported digest method issue faced on SLES platform. Please check the issue : https://github.com/winstonjs/winston-daily-rotate-file/issues/340

wbt commented 2 years ago

Merged, but I don't have permission to publish on npm. @DABH might be able to change that, or @mattberther might be able to publish.

DABH commented 2 years ago

@wbt Ah, I could add you on GitHub, but @mattberther is the only one with permissions on NPM. @mattberther , perhaps you could add me and @wbt on NPM? (We seem to be the two primary Winston maintainers right now…)

wbt commented 2 years ago

On this publish, I also somewhat defer to @mattberther for making release notes as the GitHub release tags haven't been kept up with npm releases, and there's no visible changelog to know when to go back to.

mattberther commented 2 years ago

@wbt @DABH Are you suggesting that you're willing to take over the maintenance of this project? As you likely see, I've not been able to give this project the attention it needs due to a variety of reasons. If you both are willing, I'm happy to turn the project over to you both.

DABH commented 2 years ago

@mattberther Don’t be humble, you have been a fantastic maintainer for this project over the years :) I can’t commit to any help beyond possibly doing some releases sometimes, but if that would ease your maintenance burden at all, would be happy to volunteer (though I have to caveat that my non-existent free time is already spread a bit thin with Winston and colors.js)

wbt commented 2 years ago

Basically the same as what @DABH said, but with the further caveat that I would prefer deferring to you for the reasons noted above. Somehow (pretty easy to see how, actually), when I became a committer on winston, I wound up getting notifications for all the issues on winston-daily-rotate file as well.