search

winstonjs / winston-mongodb

A MongoDB transport for winston
https://github.com/winstonjs/winston-mongodb
296 stars 125 forks source link

Bump mongodb to 6.5.0 #290

Closed Bharat94389 closed 2 months ago

Bharat94389 commented 7 months ago

see #218

Changes done:

@DABH can you please have a look at this PR

KoshelevS commented 2 months ago

@DABH Is it possible to merge this PR?

DABH commented 2 months ago

I can merge this but need to think about versioning. Since default options are changing, this feels like it should be a major version release of winston-mongodb. Do you folks agree?

yurijmikhalevich commented 2 months ago

@DABH, I agree.

KoshelevS commented 2 months ago

Sure. No problem.

DABH commented 2 months ago

@Bharat94389 Any chance you can rebase this PR so I can merge it? (Or any other volunteers?)

Bharat94389 commented 2 months ago

@DABH updated the PR please have a look

DABH commented 2 months ago

@Bharat94389 Thanks for updating! It looks like there's now a test failure that doesn't occur on master. Perhaps you have to just do npm install ip -g --save on your branch? Anyway, should be good to merge once we get the tests passing again... thanks again for helping get this done!

Bharat94389 commented 2 months ago

@DABH tried installing ip globally but didn't work so added as a dev package, and ran all the testcases locally as well.

DABH commented 2 months ago

Whoops, don't know why I typed -g, sorry, muscle memory! Looks like tests are passing now so I will merge. Thank you again!

DABH commented 2 months ago

Hey @yurijmikhalevich could I please get write permissions for the NPM repo https://www.npmjs.com/package/winston-mongodb so I can push out this major release? Thanks! (I'm dabh on NPM)

DABH commented 1 month ago

@yurijmikhalevich sorry to pester, but gentle bump on the above - any help is appreciated :)

yurijmikhalevich commented 1 month ago

@DABH, done. Thank you! :)

yurijmikhalevich commented 1 month ago

FYI @indexzero