winstonma / MMM-HK-Transport

MagicMirror² module - Hong Kong Transport station monitor
GNU Affero General Public License v3.0
6 stars 1 forks source link

Mirror only displaying "Loading" #1

Closed Aznbaka closed 4 years ago

Aznbaka commented 4 years ago

Hi,

Thanks for your work on this module! I've just added the module and it just remains on "Loading".

Screenshot at 16-11-40

Do you know if this is because of the new update on the station format ? It seems like it is now different (with Chinese characters embedded in the stopID. (i.e.: Kowloon Central Post Office station link is now : https://citymapper.com/hong-kong/bus/stops/九龍中央郵政局-kowloon-central-post-office-n-1 )

Thanks!

winstonma commented 4 years ago

Yes you are right. This module is using API version 2 and currently they are using API version 3.

Let me update the API

winstonma commented 4 years ago

Hi @Aznbaka I made a new commit

Please check if it is working.

Aznbaka commented 4 years ago

Hi @winstonma I just tried again after updating the module but it still seems to be the same. Stuck on "Loading".

winstonma commented 4 years ago

Hmm... would you mind trying the following config and see if it work first?

    {
      module: 'MMM-HK-Transport',
      position: 'top_right',
      config: {
        stops: [
          {
            stopID: 'HKStop_KowloonCentralPostOffice_N_1'
          }
        ]
      }
    },

Currently the new version would show every line (including inactive), will try to fix that in later commit.

Thanks

Aznbaka commented 4 years ago

It seems working now! Apparently I had a typo in the stopID.

Thanks a lot for your help!! Looking forward to your new commit!

winstonma commented 4 years ago

Thanks for the bug report.

I focused on MMM-HK-KMB and didn't really update this for a while.

Aznbaka commented 4 years ago

One last question, I've noticed that the module won't actually display the bus lines with exact ETA time:

Untitled2 Untitled

Is it the expected behavior ?

Thanks!

winstonma commented 4 years ago

Nono I just didn't read the returned value carefully. It is being fixed. Please update the module and let me know if there are problems.

Feature request are also welcomed

BTW I will hide the inactive route.

winstonma commented 4 years ago

@Aznbaka I just updated the module. Please use npm install as there are new dependency. This module should now support Van, Tram too.

Please reopen the ticket if you see the problem again.