winstxnhdw / lc-hax

A powerful, feature-rich and highly performant internal cheat for the co-op indie horror video game, Lethal Company.
78 stars 25 forks source link

feat/fix: Defender whitelist script, stunclick bug, ESP bugs #172

Closed armorfid closed 6 months ago

armorfid commented 6 months ago

Side-note, the ESP seems to interfere with ReservedItemSlot mods when joining, not idea why

I'm not 100% sure lc-hax is the problem, but those mods started getting unreliable around the time the ESP was added, further investigation needed

winstxnhdw commented 6 months ago

Side-note, the ESP seems to interfere with ReservedItemSlot mods when joining, not idea why

I'm not 100% sure lc-hax is the problem, but those mods started getting unreliable around the time the ESP was added, further investigation needed

I think it's more likely that a patch is breaking the mods, since 99% of mods just use patches and our patches might be causing some race conditions.

armorfid commented 6 months ago

I think it's more likely that a patch is breaking the mods, since 99% of mods just use patches and our patches might be causing some race conditions.

looks like reserved item mods are bugged even when not running lc-hax, so nevermind I guess

I dug a bit, the bug happens with ReservedItemSlotCore v1.7.2+ released last weekend, the dev added some server-client syncing code, but didn't add a syncing timeout in case the host doesn't have the mod, so the client never initializes... reverted to v1.7.1 and it's fine now, although that version has other bugs

winstxnhdw commented 6 months ago

Honestly, I still don't think we should put that script in yet. It's really about the message we are giving to users. I want them to strongly, and consciously make the decision to exclude the injector from their AVs.

winstxnhdw commented 6 months ago

Thank you again for the great work!

armorfid commented 6 months ago

Honestly, I still don't think we should put that script in yet. It's really about the message we are giving to users. I want them to strongly, and consciously make the decision to exclude the injector from their AVs.

In order to run the batch script, one would have to open the submodules folder, right-click the file, run as administrator, and accept the UAC dialog. That's a very conscious decision in my book... Also, the command you provided won't work unless they explicitly open PowerShell as admin and cd into the lc-hax folder. Something like this would probably be more obvious:

Set-MpPreference -ExclusionPath "PUT_THE_PATH_TO_LC_HAX_FOLDER_HERE"
Set-MpPreference -ExclusionPath "$env:TEMP\.net\SharpMonoInjector"

Although, from experience, asking the average user to modify a command line before usage is sometimes asking too much of them 😆

winstxnhdw commented 6 months ago

If they don't have the mind to do it, then it's probably best they don't do anything.

armorfid commented 6 months ago

lol maybe you're right, I guess I'm too used to people yelling at me if I don't hold their hands... I do think the readme could still benefit from having a mention about cd'ing into the lc-hax folder before using the command.

winstxnhdw commented 6 months ago

For sure, I'll add it tomorrow

armorfid commented 6 months ago

also $MyInvocation doesn't exist outside a script, this is the proper command:

Add-MpPreference -ExclusionPath $pwd, "$env:TEMP\.net\SharpMonoInjector"

using Set-MpPreference overwrote all my previous exclusions.........

winstxnhdw commented 6 months ago

Oops, good catch. Sorry about that.