Closed Linkis20 closed 5 months ago
Great work and thanks for the contribution!
Just a nit but because they all have different method signatures. You do not have to separate them out into different classes and can place all the patches into the same class. Just move the HarmonyPatch attribute to the methods instead of the class.
The Setting.EnableGodMode
flag prevents infinite Masked spawn when player is grabbed during God mode.
Combined them
I would suggest to remove the !Setting.EnableGodMode and find a better approach to dodge the unlimited masked spawn if you remove demi-god
Why?
Why?
Kinda ruins the game, makes it way too easy and people can easily figure that you are in godmode. Demi god was good because it allows you to be still targeted but not harmed by enemies, which makes it more vanilla like and players dont have as much suspicions
But you are literally in God mode..
But you are literally in God mode..
Yeah but enemies should still target you regardless? Unless ignore is specified
Okay then should I just bring back demigod
for this?
Okay then should I just bring back
demigod
for this?
Or just remove the !setting.IsGodMode from the condition, i commented it out and even if a masked catches me i dont see any issues here.
Oh do you not get the infinite masked capture glitch?
Oh do you not get the infinite masked capture glitch?
Yep, you can test it out, sure a masked will spawn but you can still dodge it out
@armorfid since it's no longer a problem in v49, I'll remove it.
https://github.com/winstxnhdw/lc-hax/issues/241 Fixed targetPlayer and Nutcracker
Puffer: Will see you and create smoke but will not bite you
Girl: Will haunt you but will not move or be able to kill you
Mask: Will look at you but can't kill you.
Giant: Will not see you but can get killed if touched.
I tried to change PufferAI but got errors that playerIsInLOS did not exist Idk why, PufferAI class has that property...
Also is line 10 !Setting.EnableGodMode needed?