winstxnhdw / lc-hax

A powerful, feature-rich and highly performant internal cheat for the co-op indie horror video game, Lethal Company.
77 stars 25 forks source link

feat/docs: add `rejoin` bind #346

Closed winstxnhdw closed 4 months ago

winstxnhdw commented 5 months ago

Summary

@D1GQ, apologies for not using your original PR. There were too many merge conflicts when pulling. Always do this before creating a new PR if you want to prevent them from happening. Also, please review and see if I am missing any of your features or if you think something should be implemented differently.

Closes #343 and #342

joep26020 commented 5 months ago

not working

Totoqoe commented 5 months ago

not working

I believe this is a separate branch so it wont auto update

joep26020 commented 5 months ago

not working

I believe this is a separate branch so it wont auto update

? so how do i use it?

D1GQ commented 5 months ago

Summary

  • Rejoin recently joined lobby with Shift + F5.
  • If your clipboard contains a valid Steam ID, the bind will join that lobby instead.
  • All in only 27 lines

@D1GQ, apologies for not using your original PR. There were too many merge conflicts when pulling. Always do this before creating a new PR if you want to prevent them from happening. Also, please review and see if I am missing any of your features or if you think something should be implemented differently.

Closes #343 and #342

Everything looks fine but it would be nice if some Lobby information would be displayed in the top left and have it toggle like this. It would also be nice to have a disconnect then rejoined bind to be sure that you're the last player in the lobby for antikick.

Screenshot 2024-02-02 191328 Screenshot 2024-02-02 191348

Totoqoe commented 5 months ago

not working

I believe this is a separate branch so it wont auto update

? so how do i use it?

make a new folder for the branch and run this command git clone -b feat/rejoin --single-branch --recursive https://github.com/winstxnhdw/lc-hax.git

winstxnhdw commented 4 months ago

Summary

  • Rejoin recently joined lobby with Shift + F5.
  • If your clipboard contains a valid Steam ID, the bind will join that lobby instead.
  • All in only 27 lines

@D1GQ, apologies for not using your original PR. There were too many merge conflicts when pulling. Always do this before creating a new PR if you want to prevent them from happening. Also, please review and see if I am missing any of your features or if you think something should be implemented differently. Closes #343 and #342

Everything looks fine but it would be nice if some Lobby information would be displayed in the top left and have it toggle like this. It would also be nice to have a disconnect then rejoined bind to be sure that you're the last player in the lobby for antikick.

Screenshot 2024-02-02 191328 Screenshot 2024-02-02 191348

Why do we need another bind for disconnecting and rejoining when the user can just hold shift, press F4 then F5?

Also, there were a few reasons I didn’t add lobby information.

  1. That’s where the new death/spectate counter will be.
  2. If you are getting a Steam ID, my guess is that you have it open in a browser/discord/Steam message, and when the user copies it to the clipboard, they would already know that.

How about I have a command that prints and also adds the lobby ID to clipboard?

winstxnhdw commented 4 months ago

I think if there are no objections by the end of today, I'll go ahead with this.

D1GQ commented 4 months ago

I think if there are no objections by the end of today, I'll go ahead with this.

Yeah you can add a command that's fine but it would still be nice if there was some type of debug feature to have it, I added it myself for reasons of that nature, and it would be beneficial to have a rejoin button because if you have a steam ID in your clipboard you wouldn't be able to do F4 then F5 because you would just attempt to join the steam ID.

winstxnhdw commented 4 months ago

you wouldn't be able to do F4 then F5 because you would just attempt to join the steam ID.

I've thought of that. The clipboard is cleared after the user joins a lobby so this doesn't happen.

"So the user has to copy a new Steam ID each time?"

No, because I am still storing the recently connected lobby ID, so a rejoin would still join the same lobby. It pretty much covers every case that I can think of.