Improvements

[xAstroBoy]

Add /Suit command Add /Enemies Command Add /Spawn command Add /quota command

Fix Godmode to not break player interactions add DelayedFunction extension Fix kill Self not working by delaying the toggle on by a few seconds late giving time to execute.

[winstxnhdw]

The branch is already a mess. If you look at the file changes, you are beginning to revert our current changes.

Create a new PR with one feature each, or you can wait for me to commit them myself.

[xAstroBoy]

The branch is already a mess. If you look at the file changes, you are beginning to revert our current changes.

Create a new PR with one feature each, or you can wait for me to commit them myself.

i am working on reverting the edits that are outdated.

[winstxnhdw]

Move everything to do with EnemyController to another PR.

[xAstroBoy]

Move everything to do with EnemyController to another PR.

there's not a lot of different changes, just analyzed each AI and converted their behaviour states to enumerators which makes it easy to understand and adjusted the way to make RigidBodyKeyboard set the enemy walking/running animation based off the given imputs. i forgot to merge this before you fixed and cleaned the code properly.

[winstxnhdw]

there's not a lot of different changes

Exactly, that’s why move it to another PR. I am not reviewing another PR with dozens of things going on again.

[xAstroBoy]

@winstxnhdw there we go.

[xAstroBoy]

@winstxnhdw im sure now the files edited aren't even editing the original codes anymore, i triple checked everything.

[xAstroBoy]

@winstxnhdw i removed all the obsolete edits , just the needed changes.

[winstxnhdw]

Also, is your ReSharper not detecting my editorconfig? I see a lot of format style commits and that happens if you keep violating the editorconfig settings. Normally, it should help you autoformat the code.

[xAstroBoy]

Also, is your ReSharper not detecting my editorconfig? I see a lot of format style commits and that happens if you keep violating the editorconfig settings. Normally, it should help you autoformat the code.

apparently so...

[winstxnhdw]

I don't use Visual Studio but maybe you can look at this.

[xAstroBoy]

@winstxnhdw i turned that predicate into a extension

[xAstroBoy]

Looks solid to me.

[winstxnhdw]

Move the enemy controller stuff to another PR if you want that merged soon.

[winstxnhdw]

can you please stop adding new things to the PR. just create a new one. it’s frustrating to review code that is constantly changing. it’ll also force you to think how you can separate code better to avoid merge conflicts, which will help you with structuring your code better.

[xAstroBoy]

can you please stop adding new things to the PR. just create a new one. it’s frustrating to review code that is constantly changing. it’ll also force you to think how you can separate code better to avoid merge conflicts, which will help you with structuring your code better.

that was the last one, im enchancing /spawn to cover all enemies of all levels, not just the ones based off that level, since controlcompany does a similiar thing with a override mode, i rewrote the dictionary parsing to look better and cleaner and it will fill it once as it will find all the enemies and prefabs in all levels.

[xAstroBoy]

@winstxnhdw changes are done and finished.

[xAstroBoy]

@winstxnhdw all good now?

[xAstroBoy]

@winstxnhdw Now?

[winstxnhdw]

Nope. Still too much nonsense.

[xAstroBoy]

Nope. Still too much nonsense.

what is nonsense? I DONT GET IT WHAT IS THE ISSUE!?

[winstxnhdw]

This is why I told you to separate the PRs so we can have an easier time merging. Now you are stuck here all because you are holding unnecessary state in your suit patch.

[xAstroBoy]

This is why I told you to separate the PRs so we can have an easier time merging. Now you are stuck here all because you are holding unnecessary state in your suit patch.

the unneccessary state is not unneccessary, it caches everyting , EDITS AND RESTORES THE STATE OF THE ORIGINAL SUIT and it works, __STATE CAN CONTAIN JUST ONE VARIABLE, NOT 3!

[winstxnhdw]

Use a struct.

[xAstroBoy]

Use a struct.

Why overcomplicate it ? it works! NO NEED FOR A STRUCT!

[winstxnhdw]

Because __state only works between Prefix and Postfix. Your static fields are accessible throughout the class.

[xAstroBoy]

Because __state only works between Prefix and Postfix. Your static fields are accessible throughout the class.

BECAUSE THE PATCH HAS TO SET ONE FIELD TO OVERRIDE THE PRIVATE CLASS FIELD BEFORE EXECUTING IT!

[winstxnhdw]

How about I ask you a question? Why not, I just convert every single variable, method and class in my program to static. It's easier and apparently, 'less complicated' after all.

[xAstroBoy]

How about I ask you a question? Why not, I just convert every single variable, method and class in my program to static. It's easier and apparently, 'less complicated' after all.

These variables can and they are exposed, because there's a reason, not because there's not.

[winstxnhdw]

Sure, then why create classes or structs at all? Just store them as static fields, right? They have a reason.

[xAstroBoy]

Sure, then why create classes or structs at all? Just store them as static fields, right? They have a reason.

Because they need to be accessible from the same patch externally! Why you overcomplicate it? if you want to make it your way just do it, i dont get it why there's such a big deal just for 3 fields exposed to be edited externally!?

[winstxnhdw]

Same thing can be said, why not just use a struct? You should read up on https://en.wikipedia.org/wiki/SOLID. Using a struct instead of a static field is trivial. They both take the same amount of time to implement so why don't you just choose the better one?

Am I asking you to spend hours to profile your code for micro performance gains? No. Just write better; least accessible, typesafe, immutable code.

[xAstroBoy]

@winstxnhdw i rewrote /suit and removed the patch

[winstxnhdw]

I am not changing sell. It works better as it was.

[xAstroBoy]

I am not changing sell. It works better as it was.

issue is your algoritm does not work, i adapted to work with your grab logic and it did do nothing it said 0 and the array was always empty, unless i sell all stuff, and that works.

[winstxnhdw]

No idea what do you mean by not working. I played the entire night and used the sell command many times. Worked perfectly.

[xAstroBoy]

No idea what do you mean by not working. I played the entire night and used the sell command many times. Worked perfectly.

then just take the modified PlaceItemOnCounter and adapt it to work with .GrabObject as i did, that way when you type /sell it will not show floating items randomly flying to the desk, it will show you placing them there.

[winstxnhdw]

I want it to fly to the desk. Why would I want others to know it was me who sold the items?

[xAstroBoy]

I want it to fly to the desk. Why would I want others to know it was me who sold the items?

oh, then just adapt PlaceItemsOnDesk , it works either way without a player holding it as you will force place the item there.

[winstxnhdw]

The main branch version of sell is atomic. But you want to switch to GrabObject which requires async code, is less performant, and harder to maintain. There is no good reason to use it over what we already have.

[xAstroBoy]

The main branch version of sell is atomic. But you want to switch to GrabObject which requires async code, is less performant, and harder to maintain. There is no good reason to use it over what we already have.

i mean did you try just invoking the AddObjectToDeskServerRPC without even holding the item only? seems that is working better than setting a variable and doing that.

[winstxnhdw]

Not sure what you mean.

[xAstroBoy]

Not sure what you mean.

nevermind, i discarded all changes about the sell command, invoking the RPC only is not enough.

[winstxnhdw]

Yes, that’s how grabbables work in this game. You need to first ‘grab’ them to gain ownership of the item.

[xAstroBoy]

@winstxnhdw i hope you agree the ESP looks better. i fixed the ESP bug that rendered unexistent players as well made it change color if a player died and a body exists. Found a way to make it display dead body when a dead body player's name spawns and i gave it a different color

[xAstroBoy]

@winstxnhdw now the body shows which player is from

[winstxnhdw]

Seems like your PlayDropSFX is server-side only.

[xAstroBoy]

Seems like your PlayDropSFX is server-side only.

what do you mean?

[winstxnhdw]

I think I meant to type ‘client-side’ only.

[xAstroBoy]

I think I meant to type ‘client-side’ only.

how so? im doing it exactly how the game plays it when you drop, i couldn't find a rpc for it