Closed armorfid closed 9 months ago
Alright! Everything looks good to me. Once again, thank you @armorfid! We can proceed to merge now.
Also, in a PR, review changes are usually inevitable, which means your PR will likely be squashed and merged. We really want you to get the proper credits you deserve, so either now or in the future, I recommend creating separate PRs for individual features. This ensures that your contribution for each feature is properly given its own commit so that others know about your work.
Creating multiple PRs for such tiny changes is too much overhead for this kind of side project, even some of the suggested changes (e.g. 0.0f, avoiding nesting) is unnecessary overhead, its faster for both of us if you just merge first and change to your taste afterwards. I'm not after credits either, its a cheating tool after all and I'm on an alt account 😉 I just want to share my edits.
Sure, I'll keep that in mind for you if you submit a PR again.
Summary
Phantom