Hi there, thanks for this fantastic package. I have a minor style suggestion.
The ace-jump commands throw errors when the user hits an invalid key. For instance: (error "[AceJump] Non-printable character").
user-error is more appropriate in these situations, since these are just pilot mistakes, not actual code problems. The difference being that user-error won't pop-up a backtrace if the user has debug-on-error turned on.
If user-error is being avoided in order to support earlier Emacs versions, then I'd recommend just using a message, which also won't pop backtraces.
Hi there, thanks for this fantastic package. I have a minor style suggestion.
The ace-jump commands throw errors when the user hits an invalid key. For instance:
(error "[AceJump] Non-printable character").user-erroris more appropriate in these situations, since these are just pilot mistakes, not actual code problems. The difference being thatuser-errorwon't pop-up a backtrace if the user hasdebug-on-errorturned on.If
user-erroris being avoided in order to support earlier Emacs versions, then I'd recommend just using amessage, which also won't pop backtraces.