winteram
commented
11 years ago This is phenomenal, Steven! I'll merge your changes and take a look ASAP (which might not be until Wednesday). But way to go above and beyond!
thanks! Winter
On Mon, Feb 4, 2013 at 9:40 PM, nolach notifications@github.com wrote:
Hey Dr. Mason,
I've made the following changes to the online IAT:
-Added .htaccess to base directory to prevent caching of template text files -Prompt user if unsaved changes on exit (Note: cannot display jQuery dialog on unbeforeload event. Stuck with browser-specific modal confirm display. -Prompt user if unsaved changes when switching to new template -Fixed repainting of template form when clicking currently displayed template item -Mark template as unsaved (i.e. apply .template-unsaved class) onchange of template form. Show functional 'Save' icon in template item viewer (.template-item) -Display active template when page loads if it exists, else show new template creator -Hooked category label input to tab display (i.e. as user changes cat name, tab name changes as well) -Hooked template name (#template-name) input to template item viewer (i.e. #template-selected) -Refactored code into more smaller functions to enhance readability -Commented many non-obvious actions to assist future open-source participants -Fixed several issues with asynchronous requests (i.e. $.getJSON) -Revised saveTemplate (formerly validateTemplate) to accept success, error callbacks -Fixed several issues with file manager operations (fileManager.php): a. Saving active template with new name updates active.txt b. Deleting active template updates active.txt -Created FileMgr JavaScript object to manage interactions with outside files (i.e. cache static resources, account for future changes in filenames, etc.)
Obvious remaining issues to fix: -Saving new template prevents creation of further new templates until reload(action replaces #create-new w/.template-item) -Unwieldy HTML hard-coded into JavaScript. Possibly implement template system (e.g. jQuery-templ: https://github.com/jquery/jquery-tmpl, etc.) to streamline future development?
Thanks!
Steven Allon
You can merge this Pull Request by running
git pull https://github.com/nolach/IAT master
Or view, comment on, or merge it at:
https://github.com/winteram/IAT/pull/1 Commit Summary
- Added save functionality, fileManager fixes, etc.
File Changes
- A .htaccess https://github.com/winteram/IAT/pull/1/files#diff-0(9)
- M README https://github.com/winteram/IAT/pull/1/files#diff-1 (2)
- M core/css/experimenter.csshttps://github.com/winteram/IAT/pull/1/files#diff-2(270)
- M core/fileManager.phphttps://github.com/winteram/IAT/pull/1/files#diff-3(41)
- M core/js/experimenter.jshttps://github.com/winteram/IAT/pull/1/files#diff-4(1485)
- A core/js/jquery-cookie.jshttps://github.com/winteram/IAT/pull/1/files#diff-5(92)
- M core/templateForm.htmlhttps://github.com/winteram/IAT/pull/1/files#diff-6(174)
- M experimenter.phphttps://github.com/winteram/IAT/pull/1/files#diff-7(67)
Patch Links:
nolach
Hey Dr. Mason,
I've made the following changes to the online IAT:
-Added .htaccess to base directory to prevent caching of template text files -Prompt user if unsaved changes on exit (Note: cannot display jQuery dialog on unbeforeload event. Stuck with browser-specific modal confirm display. -Prompt user if unsaved changes when switching to new template -Fixed repainting of template form when clicking currently displayed template item -Mark template as unsaved (i.e. apply .template-unsaved class) onchange of template form. Show functional 'Save' icon in template item viewer (.template-item) -Display active template when page loads if it exists, else show new template creator -Hooked category label input to tab display (i.e. as user changes cat name, tab name changes as well) -Hooked template name (#template-name) input to template item viewer (i.e. #template-selected) -Refactored code into more smaller functions to enhance readability -Commented many non-obvious actions to assist future open-source participants -Fixed several issues with asynchronous requests (i.e. $.getJSON) -Revised saveTemplate (formerly validateTemplate) to accept success, error callbacks -Fixed several issues with file manager operations (fileManager.php): a. Saving active template with new name updates active.txt b. Deleting active template updates active.txt -Created FileMgr JavaScript object to manage interactions with outside files (i.e. cache static resources, account for future changes in filenames, etc.)
Obvious remaining issues to fix: -Saving new template prevents creation of further new templates until reload(action replaces #create-new w/.template-item) -Unwieldy HTML hard-coded into JavaScript. Possibly implement template system (e.g. jQuery-templ: https://github.com/jquery/jquery-tmpl, etc.) to streamline future development?
Thanks! Steven Allon