search

wintercg / fetch

WinterCG changes to the WHATWG Fetch standard
https://fetch.spec.wintercg.org/
Other
24 stars 0 forks source link

[ci] Make deploys fail if the spec build fails #21

Closed andreubotella closed 1 year ago

andreubotella commented 1 year ago

Our CI deploy action currently asks a server at api.csswg.org to build the spec, and then uses the response to that request as the build output. However, it does not check that the response's HTTP status code is successful, which can result in Internal Server Errors in that server being "propagated" to this spec, rather than resulting in a failed build. Similarly, fatal errors in building the spec (for invalid Bikeshed syntax, for example) would result in the list of errors being deployed.

This PR fixes that by allowing curl to fail for non-successful HTTP status codes.

andreubotella commented 1 year ago

I opened parallel PRs in wintercg/proposal-common-minimum-api#56, wintercg/runtime-keys#9 and wintercg/proposal-webcrypto-streams#8.

See https://github.com/wintercg/fetch/pull/21/commits/2d2857caa2e07ce3e765ed5263812b99e20628f5 for a test of this change.