search

wintercms / winter

Free, open-source, self-hosted CMS platform based on the Laravel PHP Framework.
https://wintercms.com
MIT License
1.36k stars 192 forks source link

WIP: twig node migration #1102

Open mjauvin opened 5 months ago

mjauvin commented 5 months ago

Starting with Twig 3.9.0, Nodes using "echo" or "print" are deprecated and should use "yield":

ref. https://github.com/twigphp/Twig/commit/0990f81500ef578225df6a22879ca25481bd26a4

LukeTowers commented 1 week ago

@jaxwilko can you merge develop into wip-laravel-11 so that this diff is useful?

jaxwilko commented 1 week ago

@LukeTowers i did, don't think github realised tho

LukeTowers commented 1 week ago

@mjauvin what's left to resolve here?

mjauvin commented 1 week ago

@mjauvin what's left to resolve here?

Our custom nodes still need to be fixed for twig 4.x

LukeTowers commented 1 week ago

Do they work with the latest Twig 3 @mjauvin? If so then we can wait to migrate to Twig 4 for v1.3 of Winter

mjauvin commented 1 week ago

Do they work with the latest Twig 3 @mjauvin? If so then we can wait to migrate to Twig 4 for v1.3 of Winter

Yes, they finally fixed their shit in twig 3.12.0