wintercms / winter

Free, open-source, self-hosted CMS platform based on the Laravel PHP Framework.
https://wintercms.com
MIT License
1.36k stars 192 forks source link

Fixed error when using taglist with a single value #1116

Closed Denoder closed 5 months ago

Denoder commented 5 months ago

I hadn't updated a while but encountered this error upon updating:

TypeError: count(): Argument #1 ($value) must be of type Countable|array, int given in /home/main/site/vendor/laravel/framework/src/Illuminate/Database/Query/Builder.php:1081
Stack trace:
#0 /home/main/site/vendor/laravel/framework/src/Illuminate/Database/Query/Builder.php(1081): count()
#1 /home/main/site/vendor/laravel/framework/src/Illuminate/Support/Traits/ForwardsCalls.php(23): Illuminate\Database\Query\Builder->whereIn()
#2 /home/main/site/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Builder.php(1872): Illuminate\Database\Eloquent\Builder->forwardCallTo()
#3 /home/main/site/vendor/winter/storm/src/Database/Builder.php(300): Illuminate\Database\Eloquent\Builder->__call()
#4 /home/main/site/vendor/laravel/framework/src/Illuminate/Support/Traits/ForwardsCalls.php(23): Winter\Storm\Database\Builder->__call()
#5 /home/main/site/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php(2330): Illuminate\Database\Eloquent\Model->forwardCallTo()
#6 [internal function]: Illuminate\Database\Eloquent\Model->__call()
#7 /home/main/site/vendor/winter/storm/src/Extension/ExtendableTrait.php(613): ReflectionMethod->invokeArgs()
#8 /home/main/site/vendor/winter/storm/src/Extension/ExtendableTrait.php(450): Winter\Storm\Database\Model->extensionCallMethod()
#9 /home/main/site/vendor/winter/storm/src/Database/Model.php(777): Winter\Storm\Database\Model->extendableCall()
#10 /home/main/site/modules/backend/formwidgets/TagList.php(132): Winter\Storm\Database\Model->__call()
#11 /home/main/site/modules/backend/formwidgets/TagList.php(110): Backend\FormWidgets\TagList->hydrateRelationSaveValue()
#12 /home/main/site/modules/backend/widgets/Form.php(1228): Backend\FormWidgets\TagList->getSaveValue()
#13 /home/main/site/modules/backend/behaviors/FormController.php(317): Backend\Widgets\Form->getSaveData()
#14 [internal function]: Backend\Behaviors\FormController->update_onSave()
#15 /home/main/site/vendor/winter/storm/src/Extension/ExtendableTrait.php(444): call_user_func_array()
#16 /home/main/site/modules/backend/classes/Controller.php(186): Backend\Classes\Controller->extendableCall()
#17 [internal function]: Backend\Classes\Controller->__call()
#18 /home/main/site/modules/backend/classes/Controller.php(631): call_user_func_array()
#19 /home/main/site/modules/backend/classes/Controller.php(489): Backend\Classes\Controller->runAjaxHandler()
#20 /home/main/site/modules/backend/classes/Controller.php(287): Backend\Classes\Controller->execAjaxHandlers()
#21 /home/main/site/modules/backend/classes/BackendController.php(161): Backend\Classes\Controller->run()
#22 /home/main/site/vendor/laravel/framework/src/Illuminate/Routing/Controller.php(54): Backend\Classes\BackendController->run()
#23 /home/main/site/modules/backend/classes/BackendController.php(111): Illuminate\Routing\Controller->callAction()
#24 /home/main/site/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(43): Backend\Classes\BackendController->callAction()
#25 /home/main/site/vendor/laravel/framework/src/Illuminate/Routing/Route.php(259): Illuminate\Routing\ControllerDispatcher->dispatch()
#26 /home/main/site/vendor/laravel/framework/src/Illuminate/Routing/Route.php(205): Illuminate\Routing\Route->runController()
#27 /home/main/site/vendor/laravel/framework/src/Illuminate/Routing/Router.php(798): Illuminate\Routing\Route->run()
#28 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(141): Illuminate\Routing\Router->Illuminate\Routing\{closure}()
#29 /home/main/site/modules/backend/classes/BackendController.php(68): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#30 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(162): Backend\Classes\BackendController->Backend\Classes\{closure}()
#31 /home/main/site/vendor/laravel/framework/src/Illuminate/Routing/Middleware/SubstituteBindings.php(50): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#32 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\Routing\Middleware\SubstituteBindings->handle()
#33 /home/main/site/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(49): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#34 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\View\Middleware\ShareErrorsFromSession->handle()
#35 /home/main/site/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(121): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#36 /home/main/site/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(64): Illuminate\Session\Middleware\StartSession->handleStatefulRequest()
#37 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\Session\Middleware\StartSession->handle()
#38 /home/main/site/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/AddQueuedCookiesToResponse.php(37): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#39 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse->handle()
#40 /home/main/site/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(67): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#41 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\Cookie\Middleware\EncryptCookies->handle()
#42 /home/main/site/plugins/application/core/http/middleware/SessionDomains.php(31): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#43 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Application\Core\Http\Middleware\SessionDomains->handle()
#44 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(116): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#45 /home/main/site/vendor/laravel/framework/src/Illuminate/Routing/Router.php(797): Illuminate\Pipeline\Pipeline->then()
#46 /home/main/site/vendor/laravel/framework/src/Illuminate/Routing/Router.php(776): Illuminate\Routing\Router->runRouteWithinStack()
#47 /home/main/site/vendor/laravel/framework/src/Illuminate/Routing/Router.php(740): Illuminate\Routing\Router->runRoute()
#48 /home/main/site/vendor/winter/storm/src/Router/CoreRouter.php(20): Illuminate\Routing\Router->dispatchToRoute()
#49 /home/main/site/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(190): Winter\Storm\Router\CoreRouter->dispatch()
#50 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(141): Illuminate\Foundation\Http\Kernel->Illuminate\Foundation\Http\{closure}()
#51 /home/main/site/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#52 /home/main/site/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ConvertEmptyStringsToNull.php(31): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle()
#53 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull->handle()
#54 /home/main/site/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/PreventRequestsDuringMaintenance.php(86): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#55 /home/main/site/vendor/winter/storm/src/Foundation/Http/Middleware/CheckForMaintenanceMode.php(25): Illuminate\Foundation\Http\Middleware\PreventRequestsDuringMaintenance->handle()
#56 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Winter\Storm\Foundation\Http\Middleware\CheckForMaintenanceMode->handle()
#57 /home/main/site/vendor/laravel/framework/src/Illuminate/Http/Middleware/HandleCors.php(49): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#58 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\Http\Middleware\HandleCors->handle()
#59 /home/main/site/vendor/winter/storm/src/Foundation/Http/Middleware/CheckForTrustedProxies.php(56): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#60 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Winter\Storm\Foundation\Http\Middleware\CheckForTrustedProxies->handle()
#61 /home/main/site/vendor/winter/storm/src/Http/Middleware/TrustHosts.php(46): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#62 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Winter\Storm\Http\Middleware\TrustHosts->handle()
#63 /home/main/site/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(116): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#64 /home/main/site/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(165): Illuminate\Pipeline\Pipeline->then()
#65 /home/main/site/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(134): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter()
#66 /home/main/site/index.php(42): Illuminate\Foundation\Http\Kernel->handle()
#67 {main}

after fixing that, i saw that the styling was off: