Closed Quendi6 closed 1 month ago
@Quendi6 can you submit this as a PR instead? It's much easier to collaborate on proposed code changes in a PR rather than an issue.
This was a "Pre-Pull Request Discussion". I assume it was not necessary. I'm a bit new to this, hope I'm doing it well. Here the pull request: https://github.com/wintercms/winter/pull/1134
Closed by #1134
Package targeted
Winter CMS
Description
If the query fails not because of a base table or view not found, the getSettingsRecord() function tries to access a $record variable that is not defined.
A correct rewrite could be :
// PR:
comments are here to explain my modifications.Maybe I'm wrong, but I think it will be better code writing
Will this change be backwards-compatible?
This seems fully backwards compatible since the return will have the same values, the only difference being that it will become impossible to encounter the "Undefined variable $record" error.