Closed Quendi6 closed 1 month ago
@Quendi6 what was the exception that you ran into that triggered this error? I specifically wrote it like that originally so that anyone getting a different exception would have to report it to me π
@LukeTowers πIn truth: none. But the way it was written triggered something in me. All the code is clean except for this, which drives me crazy.π€·ββοΈ May be some OCDs here...
β¦(wintercms#1132)
Package targeted
Winter CMS
Description
If the query fails not because of a base table or view not found, the getSettingsRecord() function tries to access a $record variable that is not defined.
Here is an excerpt commenting on the changes:
// PR:
comments are here to explain my modifications.Maybe I'm wrong, but I think it will be better code writing
Will this change be backwards-compatible?
This seems fully backwards compatible since the return will have the same values, the only difference being that it will become impossible to encounter the "Undefined variable $record" error.