search

wintercms / winter

Free, open-source, self-hosted CMS platform based on the Laravel PHP Framework.
https://wintercms.com
MIT License
1.31k stars 188 forks source link

Upgrade wikimedia/minify to the latest version #1158

Closed austinderrick closed 1 week ago

austinderrick commented 2 weeks ago

Is there a reason we still use version 2.2 of wikimedia/minify?

It is currently breaking in a weird spot with one of our combined files, causing JavaScript errors. It appears that the newest version (2.7) does not have this issue.

https://github.com/wintercms/storm/blob/develop/composer.json#L51C9-L51C36 https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/libs/Minify/+/refs/tags/2.7.0

LukeTowers commented 1 week ago

@austinderrick no, that's just the base version that we require. Composer should be pulling in the latest version that meets those requirements (i.e. 2.*).

What does composer show wikimedia/minify return for you?

austinderrick commented 1 week ago

Ah, oops! I misread that composer file.

Thanks for the clarification. Upon further investigation, the fix I'm looking for is an unreleased fix in the vendor repo.