search

wintercms / winter

Free, open-source, self-hosted CMS platform based on the Laravel PHP Framework.
https://wintercms.com
MIT License
1.38k stars 195 forks source link

Re-add "setTo" method for Illuminate\Mail\Message class #888

Closed bennothommo closed 1 year ago

bennothommo commented 1 year ago

Package targeted

Storm Library

Description

Refs:

Re-add some methods that were dropped in recent Laravel versions to maintain BC, perhaps through a Winter CMS extended class. We can perhaps make them deprecated though and encourage people to shift off them.

Will this change be backwards-compatible?

This will increase backwards compatibility.

damanic commented 1 year ago

I just got stung by this issue and landed here.

Looking into it I do not think the suggestion in this issue is likely to progress. Backwards compatibility would been a consideration for Laravel on v9 DEV. https://laravel.com/docs/9.x/upgrade#symfony-mailer

Plugins should be using the interface provided by wintercms/laravel for mail actions. so that backwards compatibility can be maintained.

The issue for wintercms as I see it relates to the commonly used wm-user-plugin which is no longer compatible with v1.2 installations: https://github.com/wintercms/wn-user-plugin/pull/21

bennothommo commented 1 year ago

Looking into this further, I think you're right, @damanic.

I had assumed that setTo was still in our docs, but it's not, and the only time this issue has come up has been from our plugin, so we'll just fix it and call it a day.