search

wintercms / winter

Free, open-source, self-hosted CMS platform based on the Laravel PHP Framework.
https://wintercms.com
MIT License
1.34k stars 191 forks source link

Add support for uploading SVGs #9

Open LukeTowers opened 3 years ago

LukeTowers commented 3 years ago

Need to integrate with https://github.com/darylldoyle/svg-sanitizer to automatically sanitize SVGs on upload and then re-add them to the list of allowed defaultExtensions, assetExtensions, and imageExtensions.

Original october#5261

github-actions[bot] commented 3 years ago

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue. If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

github-actions[bot] commented 2 years ago

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue. If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

github-actions[bot] commented 2 years ago

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue. If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

qroft commented 2 years ago

Hi Luke, i am too noobish to know if what i found out fits into your request for integrating the sanitizer or if this is a bug that i have encountered. I have allowed the SVG file type inside the cms.php configuration. When i try to upload a SVG file through the Media manager A) i do not get an error B) the file is not listed and uploaded.

So as a workaround i thought: let's upload my 6 SVG files manually via FTP. What happens is A) the files are uploaded B) the Media manager shows me "6 item(s)" to the right of the folder but when i C) enter the folder, no images are shown.

Now when i call the full path of the uploaded SVG, it is shown. In short: the SVG is uploaded and can be used, but the Media manager does not show it.

LukeTowers commented 2 years ago

What does your cms.php configuration look like?

github-actions[bot] commented 2 years ago

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue. If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

shadow5og commented 2 years ago

Hello There

Any update on this?

bennothommo commented 2 years ago

@shadow5og not at this stage, but you can enable SVG support in the Media Manager now if you wish by configuration change: https://wintertricks.com/tricks/enable-svg-support-in-media-manager

shadow5og commented 2 years ago

Alright Brother!

github-actions[bot] commented 1 year ago

This issue will be closed and archived in 3 days, as there has been no activity in this issue for the last 6 months. If this issue is still relevant or you would like to see it actioned, please respond within 3 days. If this issue is critical for your business, please reach out to us at wintercms@luketowers.ca.

LukeTowers commented 1 year ago

Initial support added in https://github.com/wintercms/storm/pull/61, awaiting further integration with the media library.

github-actions[bot] commented 1 year ago

This issue will be closed and archived in 3 days, as there has been no activity in this issue for the last 6 months. If this issue is still relevant or you would like to see it actioned, please respond within 3 days. If this issue is critical for your business, please reach out to us at wintercms@luketowers.ca.