search

wintercms / wn-builder-plugin

GUI for building plugins in Winter CMS
MIT License
35 stars 12 forks source link

Added firstDay option to datepicker control #4

Closed arvislacis closed 3 years ago

arvislacis commented 3 years ago

Added firstDay (first day of the week) option to datepicker control for Builder plugin. firstDay option itself was introduced in https://github.com/octobercms/october/pull/2940

arvislacis commented 3 years ago

@bennothommo Anything else needed from my side?

bennothommo commented 3 years ago

@arvislacis Nope, just needs to be tested.

arvislacis commented 3 years ago

@bennothommo Maybe I can help with testing somehow or (so this can be merged and closed)? Overall I don't see any major points where and how this pull request could break things or don't work, especially after the last commit which sets default value to empty string (so no default/existing configurations are changed either). For one of my personal projects this worked without any issues. :)

bennothommo commented 3 years ago

@arvislacis Looks good to me. Merging.