search

wintercms / wn-builder-plugin

GUI for building plugins in Winter CMS
MIT License
34 stars 12 forks source link

Fix tests and PluginTestCase #41

Closed mjauvin closed 1 year ago

mjauvin commented 1 year ago
mjauvin commented 1 year ago

What am I misssing here? The tests run fine locally, and that BuilderPluginTestCase class DOES exist.

bennothommo commented 1 year ago

@mjauvin what's this intending to fix? The test cases are passing in the main branch as far as I can tell?

Never mind, I see what's being tested. I'm half-tempted however to roll out a major version of Builder plugin that supports only 1.2 and sunset support for older versions, to encourage people to build plugins for 1.2. So we may not need to really test 1.1 anymore.

LukeTowers commented 1 year ago

I'm fine with that @bennothommo

mjauvin commented 1 year ago

Should we close this, then @bennothommo ?