search

wintercms / wn-builder-plugin

GUI for building plugins in Winter CMS
MIT License
34 stars 12 forks source link

Added missing CSS3 and HTML5 icons for dropdown option list #8

Closed arvislacis closed 3 years ago

arvislacis commented 3 years ago

Fixes https://github.com/wintercms/wn-builder-plugin/issues/6

LukeTowers commented 3 years ago

All of these classes should probably also be updated to reference wn-icon instead of oc-icon, would you be willing to make that change and test it in this PR as well?

arvislacis commented 3 years ago

Yeah, I will try to look into that and replace oc-icon references to wn-icon.

arvislacis commented 3 years ago

@LukeTowers Done.

Should check https://github.com/wintercms/wn-builder-plugin/pull/8/commits/d7344a4278d685ee407cab71b2cfaffc16856f90#diff-0d9b1cafb1dd3d44397cc3b50e731dd12f6ae7e1bf9078295b8902f7faeb317dR109 - I added this for compability, otherwise previously set icon is not shown in the existing plugin settings. Maybe this preg_replace() function should be placed somewhere else.

Additionally added small update into en/lang.php as we discussed in https://github.com/wintercms/winter/discussions/228

LukeTowers commented 3 years ago

LGTM, will let @bennothommo merge it since he handles releases for this plugin

bennothommo commented 3 years ago

Thanks for this @arvislacis!