search

wintercms / wn-sitemap-plugin

Sitemap plugin for Winter CMS
https://wintercms.com/
MIT License
8 stars 5 forks source link

Example multilingual sitemap v1 #10

Closed AIC-BV closed 1 year ago

AIC-BV commented 1 year ago

Mix of https://github.com/utopigstudio/octobercms-plugin-seo and https://github.com/mjauvin/wn-mlsitemap-plugin, Perhaps this can help getting started with officialy supporting multilingual sitemaps

mjauvin commented 1 year ago

This is not acceptable for the base plugin, we need to allow EXTENDING its functionality, not incorporate multilang changes in it.

LukeTowers commented 1 year ago

@mjauvin can you link this from the other PR for reference?

mjauvin commented 1 year ago

@LukeTowers for what purpose exactly ?

LukeTowers commented 1 year ago

Just for my own later reference when I review the PR to make sure that it can cover all the use cases

AIC-BV commented 1 year ago

This is not acceptable for the base plugin, we need to allow EXTENDING its functionality, not incorporate multilang changes in it.

Very well aware (as mentioned in Discord) @LukeTowers asked for a PR to see the code