search

wintercms / wn-tailwindui-plugin

Provides the TailwindUI-based modern backend skin for the Winter CMS backend
MIT License
13 stars 9 forks source link

Scrollbars visible on each page #3

Closed damsfx closed 2 years ago

damsfx commented 2 years ago

Using @apply h-screen for the layout container, gives me scrollbars in every backend pages.
https://github.com/wintercms/wn-tailwindui-plugin/blob/a34b50bd0273c1a6950ba147b08950e09b2ff968/assets/css/src/custom.css#L140 image

Tested on Windows on Firefox, Edge and Chrome.

Replacing it with height : calc(100vh - 4rem) remove the scrollbars. Need to remove layout-topmenu container's height.

mjauvin commented 2 years ago

wouldn't that only remove the vertical scrollbar @damsfx ?

mjauvin commented 2 years ago

never mind, the verticall scrollbar itself make the width too large and that by itself adds the horizontal scrollbar as well...

Denoder commented 2 years ago

change:

https://github.com/wintercms/wn-tailwindui-plugin/blob/7e74e7cdecfb35a359125354c54b49886a5e78aa/assets/css/src/custom.css#L125

to use w-full rather than w-screen

damsfx commented 2 years ago

change: to use w-full rather than w-screen

@LukeTowers Do you think you have time to make this change or do you prefer a PR?

LukeTowers commented 2 years ago

@damsfx I'd prefer a PR with screenshots if someone can manage it. Assets can be compiled with artisan mix:install to add the plugin to your project's package.json, and then artisan mix:compile --production -p winter.tailwindui to compile the assets.