search

wintercms / wn-translate-plugin

Translate plugin for Winter CMS
MIT License
13 stars 18 forks source link

Use cache instead of session for isConfigured check #47

Closed jaxwilko closed 1 year ago

jaxwilko commented 1 year ago

Internally the Translator was using the user's session to store the status of the isConfigured status. This means that for each new session it would need to run these checks again which makes no sense.

This PR switches the session storage to use cache instead, meaning the check only needs to be done once for all users.

LukeTowers commented 1 year ago

@bennothommo tests are failing on this plugin as well, also due to the classloader changes. Is it loading the right bootstrap file?

bennothommo commented 1 year ago

I don't think the problem is the bootstrap file - it's not even reaching the tests. It seems to be failing on the post-update hooks in Composer, as though it hasn't worked out the PS-4 paths yet.

Problem is - I still can't replicate it, even following the same steps as the GitHub action.