search

wintercms / wn-translate-plugin

Translate plugin for Winter CMS
MIT License
13 stars 18 forks source link

Add support for the NestedForm form widget #9

Closed LukeTowers closed 1 year ago

LukeTowers commented 3 years ago

Replaces rainlab/translate-plugin#584

LukeTowers commented 3 years ago

@iboved this is the replacement as none of us work on RainLab plugins or October CMS anymore. Winter CMS for the win 😉

LukeTowers commented 3 years ago

@iboved if you could test this out and see if you can break it in any way that would help us get it merged :)

iboved commented 3 years ago

@LukeTowers thanks for your answer) I am checking. At the moment I have one error after switching the locale:

Call to undefined method MLNestedForm::processSaveValue

We don't have this method in the MLNestedForm or NestedForm classes.

mjauvin commented 3 years ago

@iboved can you try again with the latest changes I commited?

iboved commented 3 years ago

@mjauvin thanks, but we still don't have the "processSaveValue" method. Called here:

image

mjauvin commented 3 years ago

@mjauvin thanks, but we still don't have the "processSaveValue" method. Called here:

You're right, this is a method in backend/formwidgets/Repeater.php

@LukeTowers I assume you replicated MLRepeater which explain this method being used.

der-On commented 2 years ago

Any news on this? Would like to see it beeing finalized. Startet to dig into it myself now too.

mjauvin commented 2 years ago

@der-On if you are willing to work on this, I can merge it to a seperate branch and you'll be able to submit PRs against that branch.

mjauvin commented 1 year ago

Replaced by #64