wintergatan-community / virtual-mmx

A WebApp to program songs on a virtual Marble Machine X
https://wintergatan-community.github.io/virtual-mmx/
MIT License
36 stars 15 forks source link

Program playback #19

Closed micahswitzer closed 3 years ago

micahswitzer commented 4 years ago

This is the PR for issue #6. We've decided on using tone.js to handle the audio scheduling and playback. This PR will probably end up being mostly a translator from our format to tone's.

Pieces that need to be completed:

Note: this is only for Programs, not Performances this code will only be able to play back notes programmed on the programming wheel

AntonyGarand commented 3 years ago

Hey!
Is this PR stale, are you still working on it?
If not, I'll close the PR so someone else can take the issue!

I think most of the work is currently merged with dev, but as the PR is on master the diff isn't accurate

micahswitzer commented 3 years ago

Hey, thanks for bringing some energy back to this project!

I think most of these changes have at least made it into dev by way of @Zakgriffin. If he can confirm that this PR is no longer relevant, I can close it to help reduce the clutter.

AntonyGarand commented 3 years ago

I can confirm there are no changes from this PR which are not in dev, just had a look at the commit history!
With that in mind, as the content is pretty old, I'll close the PR, and we can open new issues if someone wants to keep improving on it!