wintersrd / pipelinewise-tap-mssql

Pipelinewise tap for Microsoft SQL Server
GNU Affero General Public License v3.0
14 stars 50 forks source link

Supporting Datetimeoffset. Bug Fix: Tinyint and Datetime2 #54

Closed s7clarke10 closed 1 year ago

s7clarke10 commented 1 year ago

tap-mssql 2.2.0 2023-08-23

This feature increases support for SQL Datatypes.

Please Note: For datetimeoffset the output follows the Singer Framework recommendation - that is the offset is emitted in UTC format.

seemiyah commented 1 year ago

Have successfully tested these changes between mssql and snowflake. column types: smallint, int, bigint, tinyint, datetimeoffset test values: low values, high values, and nulls test type: full_table and log_based load

Datetime value of 9999-12-31 23:59:59.999 also tested.

Screenshots of inputs and outputs attached.

Note that value of MSSQL value of 2023-08-22 08:24:32.1277000 +10:00 is correctly displayed as 2023-08-21 22:24:32.127 in Snowflake (NZ local time)

tap-mssql 2 2 0 - test outputs tap-mssql 2 2 0 - test inputs